Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ads onboarding for users who have not signed up to ads for new regions #5655

Closed
tmancey opened this issue Aug 14, 2019 · 6 comments · Fixed by brave/brave-core#3171
Closed
Assignees

Comments

@tmancey
Copy link
Collaborator

tmancey commented Aug 14, 2019

Show ads onboarding for users who have not signed up to ads for Argentina, Austria, Brazil, Switzerland, Chile, Colombia, Denmark, Ecuador, Israel, India, Italy, Japan, Korea, Mexico, Netherlands, Peru, Philippines, Poland, Sweden, Singapore, Venezuela and South Africa

@tmancey tmancey added this to the 0.71.x - Nightly milestone Aug 14, 2019
@tmancey tmancey self-assigned this Aug 14, 2019
@tmancey tmancey added this to New Issues in Rewards via automation Aug 14, 2019
@tmancey tmancey changed the title Show ads onboarding for users who have not signed up to Argentina, Austria, Brazil, Switzerland, Chile, Colombia, Denmark, Ecuador, Israel, India, Italy, Korea, Mexico, Netherlands, Peru, Philippines, Poland, Sweden, Singapore, Venezuela and South Africa Show ads onboarding for users who have not signed up to new regions Aug 14, 2019
@tmancey tmancey changed the title Show ads onboarding for users who have not signed up to new regions Show ads onboarding for users who have not signed up to ads for new regions Aug 14, 2019
@tmancey
Copy link
Collaborator Author

tmancey commented Aug 14, 2019

#5183

@tmancey tmancey added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 14, 2019
@tmancey tmancey added this to Terry in Rewards Team Aug 14, 2019
@tmancey tmancey moved this from New Issues to Backlog in Rewards Aug 14, 2019
@tmancey tmancey moved this from Backlog to Review/QA in Rewards Aug 14, 2019
@tmancey tmancey added the QA/Yes label Aug 14, 2019
@tmancey tmancey moved this from Terry to Closed in Rewards Team Aug 14, 2019
Rewards automation moved this from Review/QA to Done Aug 14, 2019
@tmancey tmancey moved this from Done to Waiting uplift in Rewards Aug 14, 2019
@tmancey tmancey moved this from Waiting uplift to Review/QA in Rewards Aug 14, 2019
@tmancey tmancey moved this from Review/QA to Done in Rewards Aug 14, 2019
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Oct 1, 2019

Need to verify untargeted ads received for new regions with test plan from brave/brave-core#3158

@LaurenWags
Copy link
Member

QA/Blocked until there are ad campaigns available for these regions.

@LaurenWags
Copy link
Member

Ad campaigns have been set up, waiting for #6449 to be uplifted before testing this among other things.

@LaurenWags
Copy link
Member

Unblocking as #6449 has been uplifted to 0.70.x milestone.

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Oct 18, 2019

Verification is passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Officiell version) (64 bitar)
Version 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Locale Sweden:

  • Verified on-boarding is shown for upgrade paths (from 0.69.135) for the new region Sweden. Verified I was prompted via BAT logo notification to alert the user that Ads have arrived. Ads were off by default.

image

  • Verified ads are enabled by default for fresh install for region Sweden and rewards is enabled. Ads panel UI is displayed, no Sorry message.
  • Verified ads count and estimated rewards for viewed ads gets reflected in the Ads panel
  • Verified ads history for viewed ads
  • Verified View, Click, landed and dismiss confirmation types in Confirmation.json file
  • Verified tokens are redeemed at the server-side ( Using Unix epoch converter TS)
    image

Locale Denmark:

  • Verified on-boarding is shown for upgrade paths (from 0.69.135) for the new region Denmark. Verified I was prompted via BAT logo notification to alert the user that Ads have arrived. Ads were off by default.

image

  • Verified ads are enabled by default for fresh install for region Denmark and rewards is enabled. Ads panel UI is displayed, no Sorry message.
  • Verified ads count and estimated rewards for viewed ads gets reflected in the Ads panel
  • Verified ads history for viewed ads
  • Verified View, Click, landed and dismiss confirmation types in Confirmation.json file
  • Verified tokens are redeemed at the server-side ( Using Unix epoch converter TS)

image

Locale Netherlands

  • Verified on-boarding is shown for upgrade paths (from 0.69.135) for the new region Netherlands. Verified I was prompted via BAT logo notification to alert the user that Ads have arrived. Ads were off by default.

image

  • Verified ads are enabled by default for fresh install for region Netherlands and rewards is enabled. Ads panel UI is displayed, no Sorry message.
  • Verified ads count and estimated rewards for viewed ads gets reflected in the Ads panel
  • Verified ads history for viewed ads
  • Verified View, Click, landed and dismiss confirmation types in Confirmation.json file
  • Verified tokens are redeemed at the server-side ( Using Unix epoch converter TS)

image

Locale Israel:

  • Verified on-boarding is shown for upgrade paths (from 0.69.135) for the new region Israel. Verified I was prompted via BAT logo notification to alert the user that Ads have arrived. Ads were off by default.

image

  • Verified ads are enabled by default for fresh install for region Israel and rewards is enabled. Ads panel UI is displayed, no Sorry message.
  • Verified ads count and estimated rewards for viewed ads gets reflected in the Ads panel
  • Verified ads history for viewed ads
  • Verified View, Click, landed and dismiss confirmation types in Confirmation.json file
  • Verified tokens are redeemed at the server-side ( Using Unix epoch converter TS)

image

Locale Switzerland:

  • Verified on-boarding is shown for upgrade paths (from 0.69.135) for the new region Switzerland. Verified I was prompted via BAT logo notification to alert the user that Ads have arrived. Ads were off by default.

image

  • Verified ads are enabled by default for fresh install for region Switzerland and rewards is enabled. Ads panel UI is displayed, no Sorry message.
  • Verified ads count and estimated rewards for viewed ads gets reflected in the Ads panel
  • Verified ads history for viewed ads
  • Verified View, Click, landed and dismiss confirmation types in Confirmation.json file
  • Verified tokens are redeemed at the server-side ( Using Unix epoch converter TS)

image

Locale South Africa:

  • Verified on-boarding is shown for upgrade paths (from 0.69.135) for the new region South Africa. Verified I was prompted via BAT logo notification to alert the user that Ads have arrived. Ads were off by default.

image

  • Verified ads are enabled by default for fresh install for region South Africa and rewards is enabled. Ads panel UI is displayed, no Sorry message.
  • Verified ads count and estimated rewards for viewed ads gets reflected in the Ads panel
  • Verified ads history for viewed ads
  • Verified View, Click, landed and dismiss confirmation types in Confirmation.json file
  • Verified tokens are redeemed at the server-side ( Using Unix epoch converter TS)

image

Locale Brazil:

  • Verified on-boarding is shown for upgrade paths (from 0.69.135) for the new region Brazil. Verified I was prompted via BAT logo notification to alert the user that Ads have arrived. Ads were off by default.
    image

  • Verified ads are enabled by default for fresh install for region Brazil and rewards is enabled. Ads panel UI is displayed, no Sorry message.

  • Verified ads count and estimated rewards for viewed ads gets reflected in the Ads panel

  • Verified ads history for viewed ads

  • Verified View, Click, landed and dismiss confirmation types in Confirmation.json file

  • Verified tokens are redeemed at the server-side ( Using Unix epoch converter TS)

image

Locale Austria:

  • Verified on-boarding is shown for upgrade paths (from 0.69.135) for the new region Austria. Verified I was prompted via BAT logo notification to alert the user that Ads have arrived. Ads were off by default.

image

  • Verified ads are enabled by default for fresh install for region Austria and rewards is enabled. Ads panel UI is displayed, no Sorry message.
  • Verified ads count and estimated rewards for viewed ads gets reflected in the Ads panel
  • Verified ads history for viewed ads
  • Verified View, Click, landed and dismiss confirmation types in Confirmation.json file
  • Verified tokens are redeemed at the server-side ( Using Unix epoch converter TS)

image

Locale Argentina:

  • Verified on-boarding is shown for upgrade paths (from 0.69.135) for the new region Argentina. Verified I was prompted via BAT logo notification to alert the user that Ads have arrived. Ads were off by default.
    image

  • Verified ads are enabled by default for fresh install for region Argentina and rewards is enabled. Ads panel UI is displayed, no Sorry message.

  • Verified ads count and estimated rewards for viewed ads gets reflected in the Ads panel

  • Verified ads history for viewed ads

  • Verified View, Click and dismiss confirmation types in Confirmation.json file. No landed confirmations due to Brave Ads target URLs that redirect to a different hostname are not sustained #4026

  • Verified tokens are redeemed at the server-side ( Using Unix epoch converter TS)

image

Verified passed with

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)

For these regions: Argentina, Chile, Colombia, Ecuador, Mexico, Peru, Philippines, Venezuela, Austria, Brazil, Switzerland, Denmark, Israel, India, Italy, South Korea, Netherlands, Poland, Sweden, Singapore, and South Africa (Japan was covered with #5656 ):

  • Verified upgrading from 0.69.135 with Rewards on and Ads not available in this region. Verified was prompted via BAT logo notification to alert user that Ads have arrived. Ads were off by default.
  • Verified enabling Rewards on fresh install enabled Ads.
  • Verified ad catalog was downloaded.
  • Verified untargeted Ad notifications were served. Verified Ad panel updated as expected with Estimated BAT and Ads viewed counts.
  • Verified view, click, dismiss, landed in confirmations.json.
  • Verified was able to redeem tokens with the server.
    Some example screenshots:
    Austria Upgrade:

Austria-Upgrade

Austria Clean Install:
Austria-clean install

Philippines Upgrade:
Philippines - Upgrade

Philippines Clean Install:
Philippines - Clean Install

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS

For these regions: Argentina(es_AR), Chile, Colombia, Ecuador, Mexico, Peru, Philippines, Venezuela, Austria, Brazil, Switzerland, Denmark, Israel, India, Italy, Japan, South Korea, Netherlands, Poland, Sweden, Singapore, and South Africa:

  • Verified upgrading from 0.69.135 with Rewards on and Ads not available in this region. Verified was prompted via BAT logo notification to alert user that Ads have arrived. Ads were off by default.
  • Verified enabling Rewards on fresh install enabled Ads.
  • Verified ad catalog was downloaded.
  • Verified untargeted Ad notifications were served. Verified Ad panel updated as expected with Estimated BAT and Ads viewed counts.
  • Verified view, click, dismiss, landed in confirmations.json.
  • Verified was able to redeem tokens with the server.

Poland Upgrade
image

Poland Clean install
image

Argentina Upgrade
image

Argentina Clean install
image

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS

For these regions: Argentina(es_AR), Chile, Colombia, Ecuador, Mexico, Peru, Philippines, Venezuela, Austria, Brazil, Switzerland, Denmark, Israel, India, Italy, Japan, South Korea, Netherlands, Poland, Sweden, Singapore, and South Africa:

  • Verified upgrading from 0.69.135 with Rewards on and Ads not available in this region. Verified was prompted via BAT logo notification to alert user that Ads have arrived. Ads were off by default.
  • Verified enabling Rewards on fresh install enabled Ads.
  • Verified ad catalog was downloaded.
  • Verified untargeted Ad notifications were served. Verified Ad panel updated as expected with Estimated BAT and Ads viewed counts.
  • Verified view, click, dismiss, landed in confirmations.json.
  • Verified was able to redeem tokens with the server.

Some locales needed to be forced with the following command:
LANG=[language_code].UTF-8 LANGUAGE=[language_code] /usr/bin/brave-browser
For example:
LANG=es_AR.UTF-8 LANGUAGE=es_AR /usr/bin/brave-browser

Logged #6560

Poland Upgrade
image

Poland Clean install
image

Argentina Upgrade
image

Argentina Clean install
image

Brazil Upgrade
image

Brazil Clean install
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants