Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration costs should be cheaper (half price?) #280

Closed
igormcoelho opened this issue Jun 22, 2018 · 7 comments
Closed

Migration costs should be cheaper (half price?) #280

igormcoelho opened this issue Jun 22, 2018 · 7 comments
Labels
enhancement Type - Changes that may affect performance, usability or add new features to existing modules.

Comments

@igormcoelho
Copy link
Contributor

In my opinion, Migration is very useful for fixing bugs, so it should be cheaper than a regular deploy (but still expensive to not create frankstein lifelong contracts). Is it reasonable to propose half the price on migrations?

@igormcoelho
Copy link
Contributor Author

Do you have any thoughts on this @shargon ?

@vncoelho
Copy link
Member

vncoelho commented Jun 22, 2018

I also agree, Igor.

It would be hard to really count with the goodwill of everyone to use Migrate for the same price.

On the other hand, Aigor, we could have a rule, if Migrating with an AVM with lower size than the previous one.
Because the AVM could now be something very very more complex and people just keep selling their previous SC ownership's. 🗡️
HAuehauehauhueaea

@igormcoelho
Copy link
Contributor Author

igormcoelho commented Jun 22, 2018

Yeah, that's true Vitor... but if it's a NEP5 for example, no one will trust a contract with a general migration scheme (it could be very easy for the owner to steal any kind of tokens). So, in general migration assumes trusts and risk, which can be smaller than the risk of bugs (the main intention of migration I believe). I also believe most cases will increase the AVM (to include the bugfix), so it's hard to reduce... although that would be good certainly.

@vncoelho
Copy link
Member

That is right.

There could be other mechanisms for thinking about these cases in which Migration was done improperly.

@erikzhang erikzhang added the enhancement Type - Changes that may affect performance, usability or add new features to existing modules. label Jun 23, 2018
@erikzhang
Copy link
Member

The pricing structure will be adjusted in NEO 3.0, please wait for the new white paper.

@shargon
Copy link
Member

shargon commented Jun 23, 2018

Could be cheaper, but like this

var dif=(OldContractSize-NewContractSize)

This ensure that you don't create a contract with few bytes, and then you use migration for fill the contract

@erikzhang erikzhang added this to the NEO 3.0 milestone Jun 25, 2018
@erikzhang
Copy link
Member

See #286

@erikzhang erikzhang removed this from the NEO 3.0 milestone Dec 6, 2019
Thacryba pushed a commit to simplitech/neo that referenced this issue Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Changes that may affect performance, usability or add new features to existing modules.
Projects
None yet
Development

No branches or pull requests

4 participants